Adding register_trainable logic to RayTuneExecutor #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR registers the trainable function passed to
tune.runusing theray.tuneutil functionregister_trainable. This fix is necessary in order ensure that the trainable function is accessible to all Ray processes in a cluster. Moreover, when running several parallelludwig.hyperoptcalls on a given ray cluster, it is necessary to have a unique trainable function for each experiment. Doing so prevents the underlying objects of different experiments (i.e.self.decode_ctx) from being shared. A unique trainable function name is created by generating a hash of the experiment config.cc: @tgaddair