Fixed bug in EthosBinary dataset class and model directory copying logic in RayTuneReportCallback #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n process_downloaded_dataset
…n downloading sst datasets
w4nderlust
reviewed
Mar 24, 2021
| @@ -722,7 +723,14 @@ def on_epoch_end(self, trainer, progress_tracker, save_path): | |||
| if trainer.is_coordinator(): | |||
| with tune.checkpoint_dir(step=progress_tracker.epoch) as checkpoint_dir: | |||
| checkpoint_model = os.path.join(checkpoint_dir, 'model') | |||
| shutil.copytree(save_path, checkpoint_model) | |||
| if not os.path.isdir(checkpoint_model): | |||
There was a problem hiding this comment.
Maybe add a comment here about the fact that the previous implementation was copytree (you can leave that line commented) but that that's not atomic and so we have to do this temp + move thing, otherwise in the future we may forget about it and maybe replace it with copytree again :)
There was a problem hiding this comment.
great feedback -- addressed in this commit here: c924b9f
tgaddair
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs:
RayTuneReportCallbackis atomic: prior to this addition, issues arose where files within the model checkpoint directory were being accessed before being completely written.cc: @tgaddair