Added support for cloud object storage (S3, GCS, ADLS, etc.) #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgaddair
changed the title
w4nderlust
reviewed
May 5, 2021
|
|
||
|
|
||
| @contextlib.contextmanager | ||
| def download_h5(url): |
There was a problem hiding this comment.
why download_h5 and not open_h5?
There was a problem hiding this comment.
also does this work with remote urls? I guess if it's remote fsspec.open_local downloads it first?
There was a problem hiding this comment.
download_h5 will first download the remote file to local, then open it for read-only.
upload_h5 opens the file for write then uploads to the remote url.
The open_local just means to download the file locally before opening, yes, as opposed to streaming. This is primarily for the purpose of caching (if you intend to re-read repeatedly).
w4nderlust
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also consolidated HDF5 and Parquet caching into a single abstraction layer as part of the backend called
CacheManager. Now, local backends can optionally cache in either HDF5 or Parquet, and the newDatasetManagerabstraction will do the work of creating the appropriate dataset based on the cache format.Depends on uber/petastorm#665.