Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add combiner schema validation #1347

Merged
merged 63 commits into from
Oct 25, 2021
Merged

Add combiner schema validation #1347

merged 63 commits into from
Oct 25, 2021

Commits on Oct 1, 2021

  1. Add sub-schema.

    @ksbrar
    ksbrar committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    f8ae067 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2021

  1. Model combiner after preproc_conds.

    @ksbrar
    ksbrar committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    42ce84d View commit details
    Browse the repository at this point in the history

  2. Remove extra comments.

    @ksbrar
    ksbrar committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    ee2f749 View commit details
    Browse the repository at this point in the history

  3. Remove more prints.

    @ksbrar
    ksbrar committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    f453636 View commit details
    Browse the repository at this point in the history

  4. More test cleanup.

    @ksbrar
    ksbrar committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    1d0ba87 View commit details
    Browse the repository at this point in the history

  5. Use Pydantic model for concat combiner config params

    @tgaddair
    tgaddair committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    bf6d852 View commit details
    Browse the repository at this point in the history

  6. Switch to initializers_registry existing.

    @ksbrar
    ksbrar committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    9791d51 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'add_combiner_schema_validation' of github.com:ludwig-ai… 

    …/ludwig into add_combiner_schema_validation
    @ksbrar
    ksbrar committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    4de7b04 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2021

  1. Add Pydantic base classes.

    @ksbrar
    ksbrar committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    7dd5b2f View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2021

  1. tmp state

    @ksbrar
    ksbrar committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    8952e47 View commit details
    Browse the repository at this point in the history

  2. Added combiner schema if-then

    @tgaddair
    tgaddair committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    236e7f0 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2021

  1. tmp

    @ksbrar
    ksbrar committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    2def95c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'add_combiner_schema_validation' of github.com:ludwig-ai… 

    …/ludwig into add_combiner_schema_validation
    @ksbrar
    ksbrar committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    7a25f40 View commit details
    Browse the repository at this point in the history

  3. Initial definitions fix.

    @ksbrar
    ksbrar committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    e018b1a View commit details
    Browse the repository at this point in the history

  4. More tests

    @ksbrar
    ksbrar committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    d6562da View commit details
    Browse the repository at this point in the history

  5. More tests

    @ksbrar
    ksbrar committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    def4d7e View commit details
    Browse the repository at this point in the history

  6. Remove old validation_schema vars

    @ksbrar
    ksbrar committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    8afc99b View commit details
    Browse the repository at this point in the history

  7. Remove prints

    @ksbrar
    ksbrar committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    1ca1659 View commit details
    Browse the repository at this point in the history

  8. Remove other comments (moved to Github PR).

    @ksbrar
    ksbrar committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    6100c8a View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'upstream/master' into add_combiner_sche… 

    …ma_validation
    @ksbrar
    ksbrar committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    83665d1 View commit details
    Browse the repository at this point in the history

  10. Fix default values.

    @ksbrar
    ksbrar committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    aa68f9b View commit details
    Browse the repository at this point in the history

  11. tmp print.

    @ksbrar
    ksbrar committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    dbf678b View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2021

  1. Fixed default num_fc_layers

    @tgaddair
    tgaddair committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    d3f0644 View commit details
    Browse the repository at this point in the history

  2. tmp

    @ksbrar
    ksbrar committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    a7af3c8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'add_combiner_schema_validation' of github.com:ludwig-ai… 

    …/ludwig into add_combiner_schema_validation
    @ksbrar
    ksbrar committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    f86f34f View commit details
    Browse the repository at this point in the history

  4. PR comments.

    @ksbrar
    ksbrar committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    a033206 View commit details
    Browse the repository at this point in the history

  5. Other small fixes.

    @ksbrar
    ksbrar committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    6a05b91 View commit details
    Browse the repository at this point in the history

  6. tmp working

    @ksbrar
    ksbrar committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    3406a2d View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2021

  1. working tmp 2 - attempting to determine on-the-fly which types accept… 

    … null.
    @ksbrar
    ksbrar committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    44dd2c7 View commit details
    Browse the repository at this point in the history

  2. SequenceCombiner example - nullable param list.

    @ksbrar
    ksbrar committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    4755ccd View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2021

  1. Initial concatcombinerschema test. Need to switch missing to default,… 

    … do a full validation test.
    @ksbrar
    ksbrar committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    0831fb5 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2021

  1. Temp status. Fixed all test_combiners tests. 

    Currently, only SequenceConcatCombiner uses deserialization to a dataclass.
    @ksbrar
    ksbrar committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    7288061 View commit details
    Browse the repository at this point in the history

  2. Fix test_schema failures. Add custom field for initializers that prop… 

    …erly allows either a dict or a enum-validated string.
    @ksbrar
    ksbrar committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    6f40abd View commit details
    Browse the repository at this point in the history

  3. Update requirements.txt.

    @ksbrar
    ksbrar committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    4c28063 View commit details
    Browse the repository at this point in the history

  4. Code cleanup, dangling TODOs. Still have failures in test_experiment.

    @ksbrar
    ksbrar committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    fba2613 View commit details
    Browse the repository at this point in the history

  5. More cleanup

    @ksbrar
    ksbrar committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    34973f4 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/master' into add_combiner_schema… 

    …_validation
    @ksbrar
    ksbrar committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    c50ee4c View commit details
    Browse the repository at this point in the history

  7. More cleanup. Fix None failure on reduce_output by adding None to reg… 

    …istry in combiners.py
    @ksbrar
    ksbrar committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    edca6d8 View commit details
    Browse the repository at this point in the history

  8. Fix reduce_output test_schema.

    @ksbrar
    ksbrar committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    5c7861f View commit details
    Browse the repository at this point in the history

  9. Convert first 3 combiners to dataclass.

    @ksbrar
    ksbrar committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    ee7119a View commit details
    Browse the repository at this point in the history

  10. Get rid of allow_none=False (cleanup).

    @ksbrar
    ksbrar committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    5568add View commit details
    Browse the repository at this point in the history

  11. Add marshmallow-dataclass to requirements

    @ksbrar
    ksbrar committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    1b8b3dc View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2021

  1. temp state

    @ksbrar
    ksbrar committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    a83bccd View commit details
    Browse the repository at this point in the history

  2. Seemingly working enum generator. Pre-cleanup.

    @ksbrar
    ksbrar committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    95d4e37 View commit details
    Browse the repository at this point in the history

  3. OK working.

    @ksbrar
    ksbrar committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    98a52cd View commit details
    Browse the repository at this point in the history

  4. cleanup mini_test

    @ksbrar
    ksbrar committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    39f063d View commit details
    Browse the repository at this point in the history

  5. Working state. Adding create_type_InitializerType in schema_utils; be… 

    …cause initializers are unions that accept both dicts and strings they have trouble with the dataclass constructors - looking at combiners.py, you can see all other fields are converted and working as expected.
    @ksbrar
    ksbrar committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    e7f833a View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2021

  1. Cleaned up schema

    @tgaddair
    tgaddair committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    e796425 View commit details
    Browse the repository at this point in the history

  2. SequenceConcat

    @tgaddair
    tgaddair committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    b90540b View commit details
    Browse the repository at this point in the history

  3. Fixed tests

    @tgaddair
    tgaddair committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    329eaee View commit details
    Browse the repository at this point in the history

  4. Tabnet

    @tgaddair
    tgaddair committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    e26321a View commit details
    Browse the repository at this point in the history

  5. Transformer

    @tgaddair
    tgaddair committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    d335b5b View commit details
    Browse the repository at this point in the history

  6. Tabtransformer

    @tgaddair
    tgaddair committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    ab11c04 View commit details
    Browse the repository at this point in the history

  7. Comparator

    @tgaddair
    tgaddair committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    e8e4791 View commit details
    Browse the repository at this point in the history

  8. Fixed init

    @tgaddair
    tgaddair committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    edc0077 View commit details
    Browse the repository at this point in the history

  9. Fixed optional

    @tgaddair
    tgaddair committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    33e8dbe View commit details
    Browse the repository at this point in the history

  10. Added FloatRange

    @tgaddair
    tgaddair committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    d7e01d8 View commit details
    Browse the repository at this point in the history

  11. Fixed initializers

    @tgaddair
    tgaddair committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    1ca0ebd View commit details
    Browse the repository at this point in the history

  12. Fixed test_combiners syntax

    @tgaddair
    tgaddair committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    72ae4e1 View commit details
    Browse the repository at this point in the history

  13. Fixed tests

    @tgaddair
    tgaddair committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    2a787d5 View commit details
    Browse the repository at this point in the history

  14. Fixed load_config_with_kwargs

    @tgaddair
    tgaddair committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    2379cc6 View commit details
    Browse the repository at this point in the history

  15. Merge branch 'master' into add_combiner_schema_validation

    @tgaddair
    tgaddair committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    ec78b73 View commit details
    Browse the repository at this point in the history

  16. Removed mini_test

    @tgaddair
    tgaddair committed Oct 24, 2021
    Configuration menu
    Copy the full SHA
    6078e93 View commit details
    Browse the repository at this point in the history