Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handle empty fields with distinct_values=[] #1574

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Better handle empty fields with distinct_values=[] #1574

merged 1 commit into from
Dec 8, 2021

Conversation

hungcs
Copy link
Contributor

@hungcs hungcs commented Dec 7, 2021

No description provided.

@hungcs hungcs requested a review from tgaddair December 8, 2021 00:07
@hungcs hungcs marked this pull request as ready for review December 8, 2021 00:07
@github-actions
Copy link

github-actions bot commented Dec 8, 2021

Unit Test Results

       6 files  ±0         6 suites  ±0   2h 54m 25s ⏱️ + 7m 23s
1 216 tests +2  1 192 ✔️ +2  24 💤 ±0  0 ❌ ±0 
3 648 runs  +6  3 576 ✔️ +6  72 💤 ±0  0 ❌ ±0 

Results for commit d1e6504. ± Comparison against base commit c2c1294.

tgaddair
tgaddair approved these changes Dec 8, 2021
View reviewed changes
Copy link
Collaborator

@tgaddair tgaddair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Can you also cherry-pick into master?

@tgaddair tgaddair merged commit 9573f18 into tf-legacy Dec 8, 2021
@tgaddair tgaddair deleted the fix-empty-infer branch December 8, 2021 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgaddair tgaddair tgaddair approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hungcs @tgaddair