-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Naming scheme cleanup that includes: renaming ludwig.marshmallow
module to ludwig.validation
to avoid implicit import errors, and moving ludwig.utils.schema
into this new module.
#1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…schema_utils.py to utils.py (under folder), update all refs.
…schema_utils.py to utils.py (under folder), update all refs.
ksbrar
changed the title
fix: Rename
fix: Rename Apr 15, 2022
ludwig.marshmallow
module to avoid impolicit import errorsludwig.marshmallow
module to avoid implicit import errors
ksbrar
changed the title
fix: Rename
fix: Rename Apr 15, 2022
ludwig.marshmallow
module to avoid implicit import errorsludwig.marshmallow
module to ludwig.validation
to avoid implicit import errors
ksbrar
changed the title
fix: Rename
fix: Rename Apr 15, 2022
ludwig.marshmallow
module to ludwig.validation
to avoid implicit import errorsludwig.marshmallow
module to ludwig.validation
to avoid implicit import errors, and move ludwig.utils.schema
into it.
ksbrar
added
bug
Something isn't working
productivity and code quality
Engineer productivity, maintainability, consistency, readability
labels
Apr 15, 2022
ksbrar
changed the title
fix: Rename
fix: naming scheme cleanup that includes: renaming Apr 15, 2022
ludwig.marshmallow
module to ludwig.validation
to avoid implicit import errors, and move ludwig.utils.schema
into it.ludwig.marshmallow
module to ludwig.validation
to avoid implicit import errors, and moving ludwig.utils.schema
into this new module.
ksbrar
changed the title
fix: naming scheme cleanup that includes: renaming
fix: Naming scheme cleanup that includes: renaming Apr 15, 2022
ludwig.marshmallow
module to ludwig.validation
to avoid implicit import errors, and moving ludwig.utils.schema
into this new module.ludwig.marshmallow
module to ludwig.validation
to avoid implicit import errors, and moving ludwig.utils.schema
into this new module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
productivity and code quality
Engineer productivity, maintainability, consistency, readability
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid implicit import aliasing errors and generally clean up usage of 'schema', this PR makes two changes:
ludwig.utils.schema
intoludwig.marshmallow
.ludwig.marshmallow
module toludwig.validation
andludwig.marshmallow.marshmallow_schema_utils
toludwig.validation.schema_utils
. The structure of this folder is now the following: