Removes pinned torchtext and torch for windows. #1998
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I have a working stack on windows (Windows 10, conda, python 3.9) installed with:
But, running
ludwig train
gives the error:After removing the windows-specific pinned dependencies, everything works. I was able to train on an image dataset just fine.
So, I tentatively think that pytorch/pytorch#65473 has been fixed in torchvision 0.11.x and forward, and it should be OK to remove the pinned versions for windows... though maybe we should re-verify the original issue first.