Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes pinned torchtext and torch for windows. #1998

Merged

Conversation

dantreiman
Copy link
Collaborator

So I have a working stack on windows (Windows 10, conda, python 3.9) installed with:

% conda install pytorch torchvision torchtext torchaudio cudatoolkit=11.3 -c pytorch

torch=='1.10.1'
torchaudio='0.10.1'
torchtext=='0.11.1'
torchvision=='0.11.2'

But, running ludwig train gives the error:

pkg_resources.DistributionNotFound: The 'torchvision==0.10.1' distribution was not found and is required by ludwig

After removing the windows-specific pinned dependencies, everything works. I was able to train on an image dataset just fine.

So, I tentatively think that pytorch/pytorch#65473 has been fixed in torchvision 0.11.x and forward, and it should be OK to remove the pinned versions for windows... though maybe we should re-verify the original issue first.

@github-actions
Copy link

github-actions bot commented May 5, 2022

Unit Test Results

       6 files  ±0         6 suites  ±0   1h 30m 2s ⏱️ + 3m 22s
2 770 tests ±0  2 739 ✔️ ±0  31 💤 ±0  0 ±0 
8 310 runs  ±0  8 213 ✔️ ±0  97 💤 ±0  0 ±0 

Results for commit c1513cd. ± Comparison against base commit 20b95a0.

♻️ This comment has been updated with latest results.

@dantreiman dantreiman force-pushed the daniel/simplify_windows_requirements branch from d1e344a to c1513cd Compare May 9, 2022 19:27
Copy link
Collaborator

@tgaddair tgaddair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlogrisetti
Copy link
Contributor

I was working on a similar PR... Please note that I am seeing torch 1.11 working fine, while having some issues with 1.12 on windows.
Still trying to figure out who's the culprit :)

@dantreiman dantreiman merged commit b4cb667 into ludwig-ai:master May 11, 2022
@dantreiman dantreiman deleted the daniel/simplify_windows_requirements branch May 11, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants