Fix ray hyperopt #1999
Merged
Fix ray hyperopt #1999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinxzhao
reviewed
May 12, 2022
tgaddair
reviewed
May 13, 2022
tgaddair
reviewed
May 18, 2022
| res = ray.init( | ||
| num_cpus=4, | ||
| num_cpus=10, |
There was a problem hiding this comment.
I don't think GH runners have 10 cpus. Do we really need this many? I think if it can't run with like 6 at most, there's probably a bug somewhere.
There was a problem hiding this comment.
@tgaddair we would need at least one more CPU than the CPUs used in hyperopt trials (discussed in this slack thread).
We could artificially restrict hyperopt to run less than 6 trials so that there are CPUs available for dask computation by setting max_concurrent_trials to something less than 6. For now, I've changed the number of CPUs to 7.
tgaddair
reviewed
May 20, 2022
ShreyaR
force-pushed
the
fix-ray-hyperopt
branch
2 times, most recently
from
c69ac82
to
002eb35
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…actor, added a df_engine attribute to RayPredictor
tgaddair
reviewed
Jun 2, 2022
tgaddair
approved these changes
Jun 2, 2022
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.