Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Torchaudio fixes #2007

Merged
merged 4 commits into from
May 9, 2022
Merged

Torchaudio fixes #2007

merged 4 commits into from
May 9, 2022

Conversation

connor-mccorm
Copy link
Collaborator

This fix should fix the issues we were seeing in the audio models

@github-actions
Copy link

github-actions bot commented May 8, 2022

Unit Test Results

       6 files  ±0         6 suites  ±0   1h 28m 33s ⏱️ + 10m 45s
2 766 tests ±0  2 735 ✔️ ±0  31 💤 ±0  0 ±0 
8 298 runs  ±0  8 201 ✔️ ±0  97 💤 ±0  0 ±0 

Results for commit bd1de23. ± Comparison against base commit 88920b2.

@@ -220,7 +223,7 @@ def _transform_to_feature(
):
feature_type = audio_feature_dict[TYPE]
if feature_type == "raw":
audio_feature = np.expand_dims(audio, axis=-1)
audio_feature = np.expand_dims(audio[0], axis=-1)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a regression test we can add for the hotfix?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya good point. So since audio is a less tested feature right now, we definitely need better testing for it. Getting a test together for the the "raw" feature type in addition to a test for the remote capabilities is another (since I've been testing with an internal s3 bucket which seems a bit unorthodox). Since I need to have an audio model trained by Wednesday for the KP presentation however, I kinda need to move quick to get that together before I build out a test suite for the rest of the audio feature pipeline. I should be able to make a lot of progress through the week though assuming the default changes allow me to create the in Predibase.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, sounds good!

@connor-mccorm connor-mccorm merged commit 5209b1a into master May 9, 2022
@connor-mccorm connor-mccorm deleted the torchaudio_fixes branch May 9, 2022 15:53
geoffreyangus added a commit that referenced this pull request May 13, 2022
* first commit

* added regression test

* cleanup

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add ray tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: Geoffrey Angus <geoffrey@predibase.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants