Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes nans in dask df engine #2020

Merged
merged 1 commit into from
May 11, 2022
Merged

fixes nans in dask df engine #2020

merged 1 commit into from
May 11, 2022

Conversation

geoffreyangus
Copy link
Collaborator

No description provided.

@github-actions
Copy link

Unit Test Results

       6 files  ±0         6 suites  ±0   1h 33m 10s ⏱️ + 3m 23s
2 774 tests ±0  2 741 ✔️ ±0    33 💤 ±0  0 ±0 
8 322 runs  ±0  8 219 ✔️ ±0  103 💤 ±0  0 ±0 

Results for commit 6445c97. ± Comparison against base commit 4294d87.

@geoffreyangus geoffreyangus marked this pull request as ready for review May 10, 2022 23:51
@tgaddair tgaddair merged commit 2c3fe2e into master May 11, 2022
@tgaddair tgaddair deleted the fix-dask-nans branch May 11, 2022 00:24
geoffreyangus added a commit that referenced this pull request May 11, 2022
* fixes nans in dask df engine

* adds tests

* fixes with logs

* fixes

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* cleanup

* checking accuracy closeness

* investigates ray batcher dropping samples with logs

* clean up for PR review

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* cleanup

* add missing test param

* updated sampling to nan_percent% of rows in each col

* cleanup

Co-authored-by: Geoffrey Angus <geoffrey@predibase.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants