Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds step tracking at epoch level #2081

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Adds step tracking at epoch level #2081

merged 1 commit into from
Jun 2, 2022

Conversation

geoffreyangus
Copy link
Collaborator

This PR fixes evaluation continuing despite being at the end of steps-based training. This happens when the user trains on <1 epoch (typically while debugging).

@github-actions
Copy link

github-actions bot commented Jun 2, 2022

Unit Test Results

       6 files  ±0         6 suites  ±0   2h 10m 35s ⏱️ - 1m 22s
2 799 tests ±0  2 764 ✔️ ±0    35 💤 ±0  0 ±0 
8 397 runs  ±0  8 288 ✔️ ±0  109 💤 ±0  0 ±0 

Results for commit 1383a96. ± Comparison against base commit 698a0e0.

Copy link
Collaborator

@justinxzhao justinxzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@justinxzhao justinxzhao merged commit e4d0238 into master Jun 2, 2022
@justinxzhao justinxzhao deleted the fix-steps-break branch June 2, 2022 04:41
geoffreyangus added a commit that referenced this pull request Jun 2, 2022
geoffreyangus added a commit that referenced this pull request Jun 2, 2022
Co-authored-by: Geoffrey Angus <geoffrey@predibase.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants