Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete PR comments for hyperopt refactoring #2082

Merged
merged 5 commits into from
Jun 2, 2022

Conversation

jimthompson5802
Copy link
Collaborator

Code Pull Requests

This PR addresses remaining coments from PR #1994

Local unit test

root@1892eaa3c210:/opt/project/sandbox/pytest_area# pytest -v /opt/project/tests/integration_tests/test_hyperopt.py
=========================================================== test session starts ============================================================
platform linux -- Python 3.8.13, pytest-7.1.2, pluggy-1.0.0 -- /usr/local/bin/python
cachedir: .pytest_cache
rootdir: /opt/project, configfile: pytest.ini
plugins: typeguard-2.13.3, timeout-2.1.0, pycharm-0.7.0, cov-3.0.0, xdist-2.5.0, forked-1.4.0, anyio-3.6.1
collected 25 items

../../tests/integration_tests/test_hyperopt.py::test_hyperopt_search_alg[None] PASSED                                                [  4%]
../../tests/integration_tests/test_hyperopt.py::test_hyperopt_search_alg[variant_generator] PASSED                                   [  8%]
../../tests/integration_tests/test_hyperopt.py::test_hyperopt_search_alg[random] PASSED                                              [ 12%]
../../tests/integration_tests/test_hyperopt.py::test_hyperopt_search_alg[hyperopt] PASSED                                            [ 16%]
../../tests/integration_tests/test_hyperopt.py::test_hyperopt_search_alg[bohb] PASSED                                                [ 20%]
../../tests/integration_tests/test_hyperopt.py::test_hyperopt_search_alg[ax] PASSED                                                  [ 24%]
../../tests/integration_tests/test_hyperopt.py::test_hyperopt_search_alg[bayesopt] PASSED                                            [ 28%]
../../tests/integration_tests/test_hyperopt.py::test_hyperopt_search_alg[blendsearch] PASSED                                         [ 32%]
../../tests/integration_tests/test_hyperopt.py::test_hyperopt_search_alg[cfo] PASSED                                                 [ 36%]
../../tests/integration_tests/test_hyperopt.py::test_hyperopt_search_alg[dragonfly] PASSED                                           [ 40%]
../../tests/integration_tests/test_hyperopt.py::test_hyperopt_search_alg[hebo] PASSED                                                [ 44%]
../../tests/integration_tests/test_hyperopt.py::test_hyperopt_search_alg[skopt] PASSED                                               [ 48%]
../../tests/integration_tests/test_hyperopt.py::test_hyperopt_search_alg[optuna] PASSED                                              [ 52%]
../../tests/integration_tests/test_hyperopt.py::test_hyperopt_executor_with_metric PASSED                                            [ 56%]
../../tests/integration_tests/test_hyperopt.py::test_hyperopt_scheduler[fifo] PASSED                                                 [ 60%]
../../tests/integration_tests/test_hyperopt.py::test_hyperopt_scheduler[asynchyperband] PASSED                                       [ 64%]
../../tests/integration_tests/test_hyperopt.py::test_hyperopt_scheduler[async_hyperband] PASSED                                      [ 68%]
../../tests/integration_tests/test_hyperopt.py::test_hyperopt_scheduler[median_stopping_rule] PASSED                                 [ 72%]
../../tests/integration_tests/test_hyperopt.py::test_hyperopt_scheduler[medianstopping] PASSED                                       [ 76%]
../../tests/integration_tests/test_hyperopt.py::test_hyperopt_scheduler[hyperband] PASSED                                            [ 80%]
../../tests/integration_tests/test_hyperopt.py::test_hyperopt_scheduler[hb_bohb] PASSED                                              [ 84%]
../../tests/integration_tests/test_hyperopt.py::test_hyperopt_scheduler[pbt] PASSED                                                  [ 88%]
../../tests/integration_tests/test_hyperopt.py::test_hyperopt_scheduler[resource_changing] PASSED                                    [ 92%]
../../tests/integration_tests/test_hyperopt.py::test_hyperopt_run_hyperopt[random] PASSED                                            [ 96%]
../../tests/integration_tests/test_hyperopt.py::test_hyperopt_run_hyperopt[grid] PASSED                                              [100%]

@github-actions
Copy link

github-actions bot commented Jun 2, 2022

Unit Test Results

       6 files  ±0         6 suites  ±0   2h 21m 40s ⏱️ + 9m 43s
2 799 tests ±0  2 767 ✔️ +3    32 💤  - 3  0 ±0 
8 397 runs  ±0  8 297 ✔️ +9  100 💤  - 9  0 ±0 

Results for commit 4621bb5. ± Comparison against base commit 698a0e0.

♻️ This comment has been updated with latest results.

@justinxzhao
Copy link
Collaborator

Thank you!

@jimthompson5802 jimthompson5802 merged commit b920c86 into master Jun 2, 2022
@jimthompson5802 jimthompson5802 deleted the finish-hyperopt-pr-comments branch June 2, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants