Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename sequence_size -> max_sequence_length #2086

Merged
merged 3 commits into from
Jun 3, 2022
Merged

Rename sequence_size -> max_sequence_length #2086

merged 3 commits into from
Jun 3, 2022

Conversation

justinxzhao
Copy link
Collaborator

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 2, 2022 •
edited
Loading

Unit Test Results

       5 files   -     1         5 suites   - 1   2h 0m 18s ⏱️ - 24m 54s
2 800 tests ±    0  2 768 ✔️ ±    0  32 💤 ±  0  0 ❌ ±0 
8 275 runs   - 125  8 186 ✔️  - 114  89 💤  - 11  0 ❌ ±0 

Results for commit cdf8582. ± Comparison against base commit b920c86.

♻️ This comment has been updated with latest results.

geoffreyangus
geoffreyangus approved these changes Jun 3, 2022
View reviewed changes
Copy link
Collaborator

@geoffreyangus geoffreyangus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change!

@justinxzhao justinxzhao marked this pull request as ready for review June 3, 2022 17:58
@justinxzhao justinxzhao merged commit 3b15020 into master Jun 3, 2022
@justinxzhao justinxzhao deleted the sequence_size branch June 3, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffreyangus geoffreyangus geoffreyangus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@justinxzhao @geoffreyangus