Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Hyperopt Executor Type default to RAY #2093

Merged
merged 2 commits into from
Jun 3, 2022
Merged

Set Hyperopt Executor Type default to RAY #2093

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f94b14
feat: add setting default for executor type
jimthompson5802 Jun 3, 2022
ef5d60c
fix: key error when hyperopt config not present
jimthompson5802 Jun 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ludwig/utils/defaults.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,8 +182,8 @@ def _upgrade_deprecated_fields(config: Dict[str, Any]):
# check for legacy parameters in "executor"
if EXECUTOR in config[HYPEROPT]:
hpexecutor = config[HYPEROPT][EXECUTOR]
executor_type = hpexecutor[TYPE]
if executor_type != RAY:
executor_type = hpexecutor.get(TYPE, None)
if executor_type is not None and executor_type != RAY:
warnings.warn(
f'executor type "{executor_type}" not supported, converted to "ray" will be flagged as error '
"in v0.6",
Expand Down Expand Up @@ -391,6 +391,9 @@ def merge_with_defaults(config):
set_default_value(output_feature, PREPROCESSING, {})
set_default_value(output_feature[PREPROCESSING], "missing_value_strategy", DROP_ROW)

# ===== Hyperpot =====
set_default_value(config[HYPEROPT][EXECUTOR], TYPE, RAY)

return config


Expand Down