Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed combiner schema creation #2114

Merged
merged 2 commits into from
Jun 8, 2022
Merged

Fixed combiner schema creation #2114

merged 2 commits into from
Jun 8, 2022

Conversation

tgaddair
Copy link
Collaborator

@tgaddair tgaddair commented Jun 8, 2022

Prior import was not running before combiners had been added to the registry.

@tgaddair tgaddair requested a review from ksbrar June 8, 2022 00:19
@github-actions
Copy link

github-actions bot commented Jun 8, 2022 •
edited
Loading

Unit Test Results

       6 files  ±0         6 suites  ±0   2h 25m 1s ⏱️ + 2m 21s
2 805 tests ±0  2 773 ✔️ ±0    32 💤 ±0  0 ❌ ±0 
8 415 runs  ±0  8 315 ✔️ ±0  100 💤 ±0  0 ❌ ±0 

Results for commit b5c1298. ± Comparison against base commit 5044239.

♻️ This comment has been updated with latest results.

@ksbrar ksbrar mentioned this pull request Jun 8, 2022
Closed
ksbrar
ksbrar approved these changes Jun 8, 2022
View reviewed changes
Copy link
Collaborator

@ksbrar ksbrar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

90% sure this will pass tests

@tgaddair tgaddair merged commit aa496e3 into master Jun 8, 2022
@tgaddair tgaddair deleted the fix-combiner-schema branch June 8, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksbrar ksbrar ksbrar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tgaddair @ksbrar