Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to ensure optional imports are optional #2116

Merged
merged 10 commits into from
Jun 10, 2022
Merged

Add tests to ensure optional imports are optional #2116

merged 10 commits into from
Jun 10, 2022

Conversation

tgaddair
Copy link
Collaborator

@tgaddair tgaddair commented Jun 8, 2022

With these changes, if any distributed or hyperopt deps are imported on the critical path, it should raise an error during CI.

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

Unit Test Results

       6 files  +       2         6 suites  +2   2h 1m 12s ⏱️ + 28m 28s
2 813 tests ±       0  2 779 ✔️  -        2    34 💤 +  2  0 ±0 
8 439 runs  +2 813  8 333 ✔️ +2 774  106 💤 +39  0 ±0 

Results for commit 19e1132. ± Comparison against base commit dd026ca.

♻️ This comment has been updated with latest results.

@tgaddair tgaddair marked this pull request as ready for review June 10, 2022 02:04
@tgaddair tgaddair merged commit 2058a9b into master Jun 10, 2022
@tgaddair tgaddair deleted the dist-tests branch June 10, 2022 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants