Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set saved_weights_in_checkpoint immediately after creating model. Also adds test. #2131

Merged

Conversation

dantreiman
Copy link
Collaborator

This is a follow-up to "Prevent loading pre-trained encoder weights when loading a trained Ludwig model".

The original issue is that ludwig was loading pre-trained models from huggingface hub at inference time when running in a container.

This also ensures that models saved by versions of Ludwig prior to #1877, or models which encountered an error during training will be restored without fetching a pretrained model from model hub.

@github-actions
Copy link

Unit Test Results

       6 files  ±0         6 suites  ±0   1h 57m 50s ⏱️ - 14m 34s
2 821 tests +1  2 787 ✔️ +1    34 💤 ±0  0 ±0 
8 463 runs  +3  8 357 ✔️ +3  106 💤 ±0  0 ±0 

Results for commit 4e5dfeb. ± Comparison against base commit ae25cc4.

@dantreiman dantreiman merged commit 7a2bfd6 into ludwig-ai:master Jun 11, 2022
@dantreiman dantreiman deleted the daniel/set_pretrained_in_checkpoint branch June 11, 2022 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants