rmspe: add epsilon to avoid division by zero #2139

jppgks · 2022-06-14T17:45:23Z

github-actions · 2022-06-14T18:17:46Z

Unit Test Results

      6 files ±0       6 suites ±0 2h 16m 22s ⏱️ + 15m 40s
2 828 tests +1 2 794 ✔️ +1   34 💤 ±0 0 ❌ ±0
8 484 runs +3 8 378 ✔️ +3 106 💤 ±0 0 ❌ ±0

Results for commit 0e0e628. ± Comparison against base commit befd584.

♻️ This comment has been updated with latest results.

justinxzhao

Thanks for the quick fix! Tested this out locally on titanic and it works reasonably well.

ludwig/utils/loss_utils.py

Fixes #1281

for more information, see https://pre-commit.ci

jppgks requested a review from justinxzhao June 14, 2022 17:48

justinxzhao approved these changes Jun 15, 2022

View reviewed changes

justinxzhao reviewed Jun 15, 2022

View reviewed changes

ludwig/utils/loss_utils.py Outdated Show resolved Hide resolved

jppgks and others added 4 commits June 18, 2022 13:00

rmspe: add epsilon to avoid division by zero

f7804f9

Fixes #1281

use test convention

6c74a27

Update ludwig/utils/loss_utils.py

98ae13c

[pre-commit.ci] auto fixes from pre-commit.com hooks

0e0e628

for more information, see https://pre-commit.ci

justinxzhao force-pushed the fix-rmspe branch from 4e93ce7 to 0e0e628 Compare June 18, 2022 17:00

justinxzhao merged commit 10b04bf into master Jun 21, 2022

justinxzhao deleted the fix-rmspe branch June 21, 2022 15:15