[Torchscript] Add Vector preprocessing and postprocessing #2160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…ludwig into ts-add-vector-feature
justinxzhao
approved these changes
Jun 17, 2022
ludwig/features/vector_feature.py
Outdated
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| class _VectorPreprocessing(torch.nn.Module): | ||
| def forward(self, v: TorchscriptPreprocessingInput): |
There was a problem hiding this comment.
nit: add return type? torch.Tensor?
There was a problem hiding this comment.
Added to this function as well as the other torchscript preprocessing modules 🙂
geoffreyangus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Vector input and output features. There is a small workaround in the Vector postprocessing step to convert
predsfromDict[str, torch.Tensor]toDict[str, Any]. The alternative is to set the return type toUnion[Dict[str, torch.Tensor], Dict[str, Any]]. We prefer the former over the latter because Torchscript will complain downstream if we try to do dict operations on variables with typeUnion[Dict[str, torch.Tensor], Dict[str, Any]](i.e. if we try to do.items()iteration).