Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to packaging version instead of LooseVersion #2173

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Update to packaging version instead of LooseVersion #2173

merged 1 commit into from
Jun 21, 2022

Conversation

arnavgarg1
Copy link
Contributor

Moving from distutils to packaging to remove some deprecation warnings, for example:

DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead.
    _ray113 = LooseVersion(ray.__version__) == LooseVersion("1.13.0")

@arnavgarg1 arnavgarg1 self-assigned this Jun 21, 2022
@arnavgarg1 arnavgarg1 linked an issue Jun 21, 2022 that may be closed by this pull request
Fix deprecation warnings for disutils Version classes #2172
Closed
@github-actions
Copy link

Unit Test Results

       6 files  ±0         6 suites  ±0   2h 22m 29s ⏱️ -22s
2 828 tests ±0  2 794 ✔️ ±0    34 💤 ±0  0 ❌ ±0 
8 484 runs  ±0  8 378 ✔️ ±0  106 💤 ±0  0 ❌ ±0 

Results for commit f32c474. ± Comparison against base commit af4b102.

@arnavgarg1 arnavgarg1 marked this pull request as ready for review June 21, 2022 08:38
justinxzhao
justinxzhao approved these changes Jun 21, 2022
View reviewed changes
Copy link
Collaborator

@justinxzhao justinxzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@justinxzhao justinxzhao merged commit e6f6532 into master Jun 21, 2022
@justinxzhao justinxzhao deleted the 2172-fix-deprecation-warnings-for-disutils-version-classes branch June 21, 2022 12:53
@arnavgarg1 arnavgarg1 changed the title Update to packing version instead of LooseVersion Update to packaging version instead of LooseVersion Jun 21, 2022
@justinxzhao justinxzhao mentioned this pull request Jun 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinxzhao justinxzhao justinxzhao approved these changes

Assignees

@arnavgarg1 arnavgarg1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix deprecation warnings for disutils Version classes
2 participants
@arnavgarg1 @justinxzhao