-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix postprocessing on binary feature columns with number dtype #2189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…-ai/ludwig into fix-binary-postprocessing
geoffreyangus
requested review from
tgaddair,
justinxzhao,
brightsparc and
jeffreyftang
June 23, 2022 21:52
justinxzhao
approved these changes
Jun 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. Not totally sure why this change would causes tests to be flaky.
tgaddair
approved these changes
Jun 24, 2022
brightsparc
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the postprocessing behavior before #2058 is preserved when dealing with binary feature columns of dtype float/int. This is done primarily by reverting the changes introduced by #2058 in
ludwig/features/binary_feature.py
andludwig/visualize.py
. You can see the full changes inbinary_feature.py
andvisualize.py
relative to 0.5.2 here and here, respectively.That said, in order to achieve this, we add several checks upstream in
cast_column
to ensure that the old behavior when determining dtypes is preserved. The one caveat is that this requires callingcompute()
, which could be expensive in large datasets.