Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changing parameters on plateau. #2191

Merged
merged 2 commits into from
Jun 23, 2022
Merged

Fix changing parameters on plateau. #2191

merged 2 commits into from
Jun 23, 2022

Conversation

justinxzhao
Copy link
Collaborator

Fixes #2186

@justinxzhao justinxzhao marked this pull request as ready for review June 23, 2022 21:18
@justinxzhao justinxzhao requested a review from jppgks June 23, 2022 21:18
@@ -137,3 +135,27 @@ def test_scale_lr(learning_rate_scaling, expected_lr, tmpdir, ray_test_cluster):

actual_lr = ray.get(run_scale_lr.remote(config, data_csv, num_workers, outdir))
assert actual_lr == expected_lr


def test_changing_parameters_on_plateau(tmpdir, ray_test_cluster):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: ray_test_cluster doesn't seem used here

@github-actions
Copy link

github-actions bot commented Jun 23, 2022

Unit Test Results

       6 files  ±0         6 suites  ±0   2h 20m 37s ⏱️ + 4m 30s
2 840 tests +1  2 806 ✔️ +1    34 💤 ±0  0 ±0 
8 520 runs  +3  8 414 ✔️ +3  106 💤 ±0  0 ±0 

Results for commit fbb15f9. ± Comparison against base commit cf9060e.

♻️ This comment has been updated with latest results.

@justinxzhao justinxzhao merged commit 36787ba into master Jun 23, 2022
@justinxzhao justinxzhao deleted the plateau_fix branch June 23, 2022 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comparing invalid types to determine reduced learning rate
2 participants