Add attention scores of the vit encoder as an additional return value #2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisrall
changed the title
justinxzhao
reviewed
Jun 24, 2022
There was a problem hiding this comment.
@Dennis-Rall thanks for putting this change together.
Are there any speed implications with outputting attentions?
If so (or if you aren't sure), I suggest that we add this as a parameter in the constructor of the encoder such that this parameter would be configurable.
Please let me know if what I'm requesting is not clear.
|
@justinxzhao I don't know how this affects speed, but I think it's definitely a good idea to add this as a configurable parameter. |
dennisrall
force-pushed
the
return-attention-scores-in-vit-encoder
branch
from
f0178b8
to
4881dbf
Compare
justinxzhao
approved these changes
Jun 27, 2022
|
Are the failing hyperopt tests a result of my changes? |
Nope! Tests look good, thanks for the PR -- merging. |
abidwael
pushed a commit
that referenced
this pull request
Jul 11, 2022
…#2192) * Add returning of attention scores in the vit encoder * Add output_attentions as a configurable parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the vit's attention scores as return values.