-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pytest tmpdir fixture wherever temporary directories are used in tests. #2274
Conversation
@@ -64,7 +64,11 @@ class BaseTrainerConfig(schema_utils.BaseMarshmallowConfig): | |||
default=None, | |||
allow_none=True, | |||
min_exclusive=0, | |||
description="Size of batch to pass to the model for evaluation.", | |||
description=( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also mention auto
, which will set the eval batch size to maximize GPU bandwidth.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.