Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: non-number inputs to GBM #2418

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Bugfix: non-number inputs to GBM #2418

merged 1 commit into from
Aug 31, 2022

Conversation

jppgks
Copy link
Contributor

@jppgks jppgks commented Aug 25, 2022

Adds previously failing test + fix by casting inputs to float

@github-actions
Copy link

github-actions bot commented Aug 25, 2022 •
edited
Loading

Unit Test Results

       5 files  ±0         5 suites  ±0   2h 45m 58s ⏱️ - 31m 2s
2 978 tests +2  2 883 ✔️ +3    95 💤 ±0  0 ❌  - 1 
6 085 runs  +5  5 869 ✔️ +6  216 💤 ±0  0 ❌  - 1 

Results for commit 45e3ed2. ± Comparison against base commit 77ce9d4.

♻️ This comment has been updated with latest results.

@jppgks jppgks merged commit 24f6583 into master Aug 31, 2022
@jppgks jppgks deleted the joppe/mlf-90-gbm-encode-categorical-features-as branch August 31, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinxzhao justinxzhao justinxzhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jppgks @justinxzhao