fix: Automatically assign title to OneOfOptionsField #2480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results 6 files ±0 6 suites ±0 2h 49m 50s ⏱️ + 17m 1s For more details on these failures, see this check. Results for commit c500986. ± Comparison against base commit 5db9190. ♻️ This comment has been updated with latest results. |
connor-mccorm
approved these changes
Sep 13, 2022
justinxzhao
approved these changes
Sep 14, 2022
ksbrar
added a commit
to ksbrar/ludwig
that referenced
this pull request
Sep 14, 2022
* fix * update test
ksbrar
added a commit
that referenced
this pull request
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug for existing fields like
learning_ratewhich currently end up with a top-level title of 'tmp' and no option-specific titles.