Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type to custom combiner #2627

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Add type to custom combiner #2627

merged 1 commit into from
Oct 12, 2022

Conversation

connor-mccorm
Copy link
Collaborator

@github-actions
Copy link

github-actions bot commented Oct 11, 2022 •
edited
Loading

Unit Test Results

         5 files  ±0         5 suites  ±0   3h 7m 52s ⏱️ + 10m 35s
  3 456 tests ±0  3 380 ✔️ ±0    76 💤 ±0  0 ❌ ±0 
10 216 runs  ±0  9 983 ✔️ ±0  233 💤 ±0  0 ❌ ±0 

Results for commit c2caa8e. ± Comparison against base commit e832a7a.

♻️ This comment has been updated with latest results.

@connor-mccorm connor-mccorm mentioned this pull request Oct 11, 2022
Merged
justinxzhao
justinxzhao approved these changes Oct 12, 2022
View reviewed changes
Copy link
Collaborator

@justinxzhao justinxzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@connor-mccorm connor-mccorm merged commit f092b21 into master Oct 12, 2022
@connor-mccorm connor-mccorm deleted the CO-factor-custom_component branch October 12, 2022 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinxzhao justinxzhao justinxzhao approved these changes

@dantreiman dantreiman Awaiting requested review from dantreiman

@jppgks jppgks Awaiting requested review from jppgks

@abidwael abidwael Awaiting requested review from abidwael

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@connor-mccorm @justinxzhao