Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protos to the Ludwig project: DatasetProfile messages and Whylogs messages. #2674

Merged
merged 2 commits into from
Oct 20, 2022

Conversation

justinxzhao
Copy link
Collaborator

We copy the whylogs proto wholesale, as this seems preferable to adding the entire whylogs project as a submodule, and AFAIK there's not an elegant way to reference another project's proto.

I've also included adjustments to the pre-commit and other linting tooling so that protos are linted, and autogenerated protoc proto python code is ignored.

@github-actions
Copy link

github-actions bot commented Oct 19, 2022

Unit Test Results

         5 files   -   1           5 suites   - 1   3h 4m 1s ⏱️ - 45m 59s
  3 480 tests +13    3 403 ✔️ +58    77 💤 ±0  0  - 45 
10 283 runs   - 68  10 047 ✔️  - 17  236 💤  - 6  0  - 45 

Results for commit e4330cf. ± Comparison against base commit cb90e21.

♻️ This comment has been updated with latest results.

@arnavgarg1
Copy link
Contributor

@justinxzhao Is the plan to also push the pb2 files to Ludwig?

@justinxzhao
Copy link
Collaborator Author

@justinxzhao Is the plan to also push the pb2 files to Ludwig?

That's correct. The raw source files generated via betterproto look a lot cleaner, but we can't use them because betterproto doesn't support proto any types yet, which is used by the whylogs proto.

@justinxzhao justinxzhao merged commit 303bc56 into master Oct 20, 2022
@justinxzhao justinxzhao deleted the whylogs_proto branch October 20, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants