Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Annotations] Move feature registries into accessor functions #2818

Merged
merged 1 commit into from
Dec 7, 2022
Merged

[Annotations] Move feature registries into accessor functions #2818

merged 1 commit into from
Dec 7, 2022

Conversation

arnavgarg1
Copy link
Contributor

@arnavgarg1 arnavgarg1 commented Dec 2, 2022 •
edited
Loading

This PR moves base_type_registry, input_type_registry and output_type_registry into accessor methods so that they can't be accessed directly. It also annotates these accessor methods with the DeveloperAPI annotation.

@github-actions
Copy link

github-actions bot commented Dec 2, 2022

Unit Test Results

         6 files  ±0           6 suites  ±0   3h 36m 22s ⏱️ - 13m 19s
  3 536 tests ±0    3 461 ✔️ ±0    75 💤 ±0  0 ❌ ±0 
10 608 runs  ±0  10 365 ✔️ ±0  243 💤 ±0  0 ❌ ±0 

Results for commit 2004dc1. ± Comparison against base commit 6707eb8.

@arnavgarg1 arnavgarg1 merged commit 4a284e8 into master Dec 7, 2022
@arnavgarg1 arnavgarg1 deleted the annotate_feature_registries branch December 7, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinxzhao justinxzhao justinxzhao approved these changes

@connor-mccorm connor-mccorm connor-mccorm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arnavgarg1 @justinxzhao @connor-mccorm