Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated Gradients: reset sample_ratio to 1.0 if set #2945

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

jppgks
Copy link
Contributor

@jppgks jppgks commented Jan 17, 2023

If model.config_obj.preprocessing.sample_ratio was set for a model, it was also applied to the explanation input. For small input sizes, this could result in empty explanation inputs.

Resolution: reset sample_ratio to 1.0 before preprocessing explanation inputs.

@github-actions
Copy link

github-actions bot commented Jan 17, 2023

Unit Test Results

         6 files  ±  0           6 suites  ±0   4h 53m 25s ⏱️ - 5m 52s
  3 892 tests ±  0    3 817 ✔️ ±  0    74 💤 ±  0  1 ±0 
11 603 runs   - 24  11 393 ✔️  - 12  209 💤  - 12  1 ±0 

For more details on these failures, see this check.

Results for commit 498dab0. ± Comparison against base commit d83693a.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@tgaddair tgaddair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we set it back when we're done?

@jppgks jppgks requested a review from tgaddair January 17, 2023 22:56
@jppgks jppgks merged commit f6b40e6 into master Jan 19, 2023
@jppgks jppgks deleted the empty-explain-inputs branch January 19, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants