Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable sampling in preprocessing or when it results in too few rows #3117

Merged
merged 8 commits into from
Mar 1, 2023

Conversation

ShreyaR
Copy link
Contributor

@ShreyaR ShreyaR commented Feb 18, 2023

No description provided.

@ShreyaR ShreyaR requested a review from jppgks February 18, 2023 00:26
@github-actions
Copy link

github-actions bot commented Feb 22, 2023

Unit Test Results

         6 files  ±  0           6 suites  ±0   5h 58m 52s ⏱️ + 1m 57s
  3 980 tests +  4    3 936 ✔️ +  4    44 💤 ±0  0 ±0 
11 961 runs  +12  11 820 ✔️ +12  141 💤 ±0  0 ±0 

Results for commit 99c9fc1. ± Comparison against base commit 6b51478.

♻️ This comment has been updated with latest results.

@arnavgarg1
Copy link
Contributor

@ShreyaR can we add a test?

@ShreyaR ShreyaR changed the title Disable sampling when it results in too few rows Disable sampling in preprocessing or when it results in too few rows Feb 27, 2023
Copy link
Contributor

@arnavgarg1 arnavgarg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🚢

@ShreyaR ShreyaR merged commit 04efab4 into master Mar 1, 2023
@ShreyaR ShreyaR deleted the conditional_sampling branch March 1, 2023 05:55
tgaddair pushed a commit that referenced this pull request Mar 1, 2023
…3117)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants