Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [REBASE] Hoist uniqueItemProperties to top of feature JSON schema #3183

Merged
merged 4 commits into from
Mar 3, 2023

Conversation

ksbrar
Copy link
Collaborator

@ksbrar ksbrar commented Mar 2, 2023

Redo of #3159 - this time from a native upstream branch rather than from my own fork.

--

Though this PR is just about moving one line of the schema (which is only relevant for AJV validation) one level up in its tree and the real issue at hand is that I'm working against marshmallow_jsonschema's rules (see this comment: #2906 (comment)), this change got me thinking about how we might want to deal with post-generation schema changes in the future.

I thought about tackling this a couple of different ways:

  • some kind of post-generation decorator that can be added to a schema
  • define a suite of schema transformations (like we already do for backwards compatibility)
  • should we maintain separate schema transformations for usage with AJV?
  • Ultimately I settled on a lightweight solution for now, but it's not ideal IMO.

@ksbrar ksbrar requested a review from abidwael March 2, 2023 22:09
Copy link
Contributor

@abidwael abidwael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad it worked!

@ksbrar
Copy link
Collaborator Author

ksbrar commented Mar 3, 2023

@abidwael I don't actually know if it did yet, no actions have run ;)

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Unit Test Results

         6 files  ±0           6 suites  ±0   6h 46m 40s ⏱️ + 28m 4s
  4 007 tests  - 1    3 964 ✔️  - 1    43 💤 ±0  0 ±0 
11 989 runs   - 1  11 857 ✔️  - 1  132 💤 ±0  0 ±0 

Results for commit ae26f77. ± Comparison against base commit 31add00.

♻️ This comment has been updated with latest results.

@ksbrar ksbrar merged commit 13e8401 into master Mar 3, 2023
@ksbrar ksbrar deleted the clone-rebase-fix-feature-jsonschema branch March 3, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants