Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [REBASE] Misc. JSON schema fixes #3187

Merged
merged 3 commits into from
Mar 5, 2023
Merged

Conversation

ksbrar
Copy link
Collaborator

@ksbrar ksbrar commented Mar 2, 2023

Redo of #3147 - this time from a native upstream branch rather than from my own fork.

--

  • Removes unnecessary staticmethod decorators on JSON type mappings
  • Removes get_preprocessing_jsonschema
  • Adds a default json_type_mapping to DictMarshmallowField

@ksbrar ksbrar requested review from tgaddair, connor-mccorm and justinxzhao and removed request for tgaddair March 3, 2023 06:33
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Unit Test Results

         6 files  ±  0           6 suites  ±0   5h 53m 14s ⏱️ - 25m 22s
  4 007 tests  -   1    3 964 ✔️  -   1    43 💤 ±0  0 ±0 
12 042 runs  +52  11 907 ✔️ +49  135 💤 +3  0 ±0 

Results for commit 3045900. ± Comparison against base commit 31add00.

@ksbrar ksbrar merged commit ca43067 into master Mar 5, 2023
@ksbrar ksbrar deleted the clone-rebase-json-fixes branch March 5, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants