Consolidate hyperopt schema in ludwig.schema.hyperopt
#3190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkinnison
changed the title
ludwig.schema.hyperoptludwig.schema.hyperopt
|
The latest failures required a rewrite of the nested parameter check because of the case where we were hyperopting over specific combiner configs, and checking against the defaults led to a validation error when |
ksbrar
reviewed
Apr 4, 2023
| field_type = fields.Float() | ||
| elif list_type is list: | ||
| field_type = fields.List(fields.Float()) | ||
| type_map = {str: fields.String, int: fields.Integer, float: fields.Float} |
| ("out_feature.foo.num_fc_layers", True), | ||
| ], | ||
| ) | ||
| def test_parameter_key_check(referenced_parameter, raises_exception): |
ludwig/config_validation/checks.py
Outdated
| else: | ||
| config.__getattribute__(k) | ||
| except AttributeError: | ||
| invalid_fields.append(nested_path) |
|
Looks like the tagger decoder failures were happening because the check was de-registered at some point. That can happen when merging |
arnavgarg1
approved these changes
Apr 5, 2023
|
Amazing work 👏 |
tgaddair
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hyperopt search algorithm schemas are defined in
ludwig.hyperopt, and they currently work with dictionary schemas rather than dataclasses. This update will move all hyperopt schema intoludwig.schema.hyperoptand update hyperopt to work with object schemas.