Guarantee determinism when sampling (either overall via sample_ratio, or while balancing data)
#3191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
arnavgarg1
changed the title
sample_ratio, or while balancing data)
arnavgarg1
added
bug
tgaddair
approved these changes
Mar 3, 2023
ShreyaR
approved these changes
Mar 3, 2023
tgaddair
pushed a commit
that referenced
this pull request
Mar 3, 2023
…`, or while balancing data) (#3191)
tgaddair
pushed a commit
that referenced
this pull request
Mar 3, 2023
…`, or while balancing data) (#3191)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't propagate the random_seed to any of our
df.samplecalls. What this means is that if there is a cache miss, or if we skip saving preprocessed inputs, it's possible that two successive calls have completely different performance because sampling is currently non-deterministic.This PR ensures that two successive calls using either
sample_ratio< 1, oroversample_minority/undersample_majorityalways samples the rows in the same order. This can be flipped by using a differentrandom_seedif needed, but will be deterministic otherwise.