Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

int: [REBASE] Remove unnecessary JSON schema code #3196

Merged
merged 4 commits into from
Mar 3, 2023

Conversation

ksbrar
Copy link
Collaborator

@ksbrar ksbrar commented Mar 3, 2023

Redo of #3136 - this time from a native upstream branch rather than from my own fork.

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Unit Test Results

         6 files  ±  0           6 suites  ±0   6h 6m 1s ⏱️ - 10m 5s
  4 009 tests ±  0    3 966 ✔️ ±  0    43 💤 ±  0  0 ±0 
11 970 runs   - 76  11 850 ✔️  - 61  120 💤  - 15  0 ±0 

Results for commit 8c19c7c. ± Comparison against base commit efd9337.

Copy link
Collaborator

@justinxzhao justinxzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ludwig/schema/model_types/base.py Outdated Show resolved Hide resolved
@ksbrar ksbrar merged commit 25b188d into master Mar 3, 2023
@ksbrar ksbrar deleted the clone-rebase-remove-backend-jsonschema branch March 3, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants