-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to specify a local or S3 HF mirror for more guaranteed loading of pre-trained HF models. #3211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgaddair
reviewed
Mar 7, 2023
tgaddair
reviewed
Mar 7, 2023
tgaddair
reviewed
Mar 7, 2023
tgaddair
reviewed
Mar 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few nits.
tgaddair
approved these changes
Mar 7, 2023
arnavgarg1
approved these changes
Mar 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Agree with @tgaddair's comments around the tests :) Great addition!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We've seen that HF servers can go down sometimes. This PR adds the ability to specify a local or S3 HF mirror for more guaranteed loading of pre-trained HF models by setting a
LUDWIG_PRETRAINED_MODELS_DIR
env variable.Implementation
If the
LUDWIG_PRETRAINED_MODELS_DIR
environment variable is set, we attempt to load the HF model from this directory, falling back to downloading from the HF hub if the model is not found, downloading fails, or if model initialization fails.LUDWIG_PRETRAINED_MODELS_DIR
can be an s3 path. Weights are copied to a local temporary directory, and the model is loaded from there.The expected structure of the
LUDWIG_PRETRAINED_MODELS_DIR
directory is:For example, if
LUDWIG_PRETRAINED_MODELS_DIR
is set tos3://my-bucket/pretrained-models
, andpretrained_model_name_or_path
is set tobert-base-uncased
, we expect to find the following files:If the
LUDWIG_PRETRAINED_MODELS_DIR
environment variable is not set, we download the model from the HF hub.