Fixes Explain step for tied weights #3214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results 6 files ± 0 6 suites ±0 6h 29m 55s ⏱️ + 35m 12s For more details on these failures, see this check. Results for commit a6f1ecc. ± Comparison against base commit e3a9416. ♻️ This comment has been updated with latest results. |
for more information, see https://pre-commit.ci
…ai/ludwig into fix-explain-tied-weights
jppgks
approved these changes
Mar 10, 2023
connor-mccorm
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the explain step for tied weights. Prior to this change, the explain step would fail with the following error:
We tracked this failure down to the fact that Captum doesn't like it when you pass duplicates of the same torch module into the integrated gradients step.
The fix for this was to create a deep copy of the tied torch module and update the computation graph used during the explanation step to use the deep copy so that every target layer passed into Captum is only forward-passed once per batch.