Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable number decoder in the decoder config #3217

Merged
merged 2 commits into from
Mar 7, 2023
Merged

Disable number decoder in the decoder config #3217

merged 2 commits into from
Mar 7, 2023

Conversation

abidwael
Copy link
Contributor

@abidwael abidwael commented Mar 7, 2023

No description provided.

@abidwael abidwael requested a review from arnavgarg1 March 7, 2023 09:58
@github-actions
Copy link

github-actions bot commented Mar 7, 2023 •
edited

Unit Test Results

         6 files  ±  0           6 suites  ±0   6h 15m 48s ⏱️ - 18m 37s
  4 044 tests +  2    4 001 ✔️ +  2    43 💤 ±0  0 ❌ ±0 
12 101 runs   - 46  11 969 ✔️  - 43  132 💤  - 3  0 ❌ ±0 

Results for commit 0595e31. ± Comparison against base commit ef0891f.

♻️ This comment has been updated with latest results.

jeffkinnison
jeffkinnison approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@jeffkinnison jeffkinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Not going to block merging based on the below comment, it was just a thought I had when reviewing the test.

tests/ludwig/config_validation/test_checks.py Show resolved Hide resolved
@jeffkinnison jeffkinnison mentioned this pull request Mar 7, 2023
Merged
@abidwael abidwael merged commit 4fefcf8 into master Mar 7, 2023
@abidwael abidwael deleted the remove-passthrough-decoder-from-schema branch March 7, 2023 22:41
@abidwael abidwael mentioned this pull request Mar 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgaddair tgaddair tgaddair left review comments

@jeffkinnison jeffkinnison jeffkinnison approved these changes

@arnavgarg1 arnavgarg1 Awaiting requested review from arnavgarg1 arnavgarg1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@abidwael @tgaddair @jeffkinnison