Add support for model.compile in PyTorch 2.0
#3246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tgaddair
commented
Mar 14, 2023
tgaddair
commented
arnavgarg1
approved these changes
Mar 15, 2023
arnavgarg1
reviewed
Mar 15, 2023
ludwig/schema/trainer.py
Outdated
Comment on lines
80
to
82
| raise ConfigValidationError( | ||
| "ECD model training requires PyTorch 2.0.0 or higher. Please upgrade PyTorch and try again." | ||
| ) |
There was a problem hiding this comment.
I would change this to compile requires PyTorch 2.0.0 or higher. Please upgrade PyTorch and try again
There was a problem hiding this comment.
That's what I get for letting Copilot write the error messages.
…nto torch-compile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.