Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes invalid keys from GBM defaults in the schema #3252

Merged
merged 3 commits into from
Mar 16, 2023
Merged

Removes invalid keys from GBM defaults in the schema #3252

merged 3 commits into from
Mar 16, 2023

Conversation

arnavgarg1
Copy link
Contributor

Title :)

Essentially encoder, decoder and loss are not valid keys for GBMs.

@arnavgarg1 arnavgarg1 added the release-0.7 Needs cherry-pick into 0.7 release branch label Mar 15, 2023
@github-actions
Copy link

Unit Test Results

         6 files  ±  0           6 suites  ±0   7h 30m 1s ⏱️ + 31m 31s
  4 088 tests +  1    4 045 ✔️ +  1    43 💤 ±0  0 ❌ ±0 
12 234 runs   - 48  12 102 ✔️  - 45  132 💤  - 3  0 ❌ ±0 

Results for commit 86af26e. ± Comparison against base commit d5f61eb.

@tgaddair tgaddair removed the release-0.7 Needs cherry-pick into 0.7 release branch label Mar 16, 2023
@arnavgarg1 arnavgarg1 merged commit 000604c into master Mar 16, 2023
@arnavgarg1 arnavgarg1 deleted the gbm_backwards_compat branch March 16, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinxzhao justinxzhao justinxzhao approved these changes

@ksbrar ksbrar Awaiting requested review from ksbrar

@geoffreyangus geoffreyangus Awaiting requested review from geoffreyangus geoffreyangus is a code owner

@tgaddair tgaddair Awaiting requested review from tgaddair tgaddair is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@arnavgarg1 @tgaddair @justinxzhao @ksbrar