Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow encoders for GBMs #3258

Merged
merged 3 commits into from
Mar 16, 2023
Merged

Allow encoders for GBMs #3258

merged 3 commits into from
Mar 16, 2023

Conversation

arnavgarg1
Copy link
Contributor

@arnavgarg1 arnavgarg1 commented Mar 15, 2023

This PR enables binary, category, number, and text features to allow encoders in the defaults section of the Ludwig config. It also removes type as a parameter from the default section of the Ludwig config for both ECD and GBM

Copy link
Collaborator

@ksbrar ksbrar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I leave it up to you and travis to verify the encoder specifics for each feature

@github-actions
Copy link

Unit Test Results

         6 files  ±  0           6 suites  ±0   7h 16m 30s ⏱️ - 6m 7s
  4 095 tests +  1    4 052 ✔️ +  1    43 💤 ±  0  0 ±0 
12 254 runs  +38  12 122 ✔️ +22  132 💤 +16  0 ±0 

Results for commit 397385f. ± Comparison against base commit 6263dd6.

tests/ludwig/schema/test_model_config.py Outdated Show resolved Hide resolved
@arnavgarg1 arnavgarg1 merged commit 0d1f4d8 into master Mar 16, 2023
@arnavgarg1 arnavgarg1 deleted the allow_encoder_gbms branch March 16, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants