Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed reduce_option=concat for auto_transformer and deberta #3291

Merged
merged 4 commits into from
Mar 27, 2023

Conversation

tgaddair
Copy link
Collaborator

Also adds @slow tests for the reduce option and replaces monkeypatching with mocks.

Copy link
Collaborator

@geoffreyangus geoffreyangus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Quick question– is there a functional difference between using PyTest's monkeypatch vs unittest's mock? Or is it just preference/convention

@tgaddair
Copy link
Collaborator Author

@geoffreyangus my concern with using monkeypatch here is that I don't believe it will "undo" itself when the fixture exits. The way it was implemented, it appears it will carry that patch through to any subsequent tests, which would be bad. The mocking here is in a context manager that will undo the mock when the context manager exits, which is what you would want.

@github-actions
Copy link

Unit Test Results

  6 files  ±       0    6 suites  ±0   21m 34s ⏱️ - 23m 30s
12 tests  - 2 474  10 ✔️  - 2 467    2 💤  -   7  0 ±0 
60 runs   - 4 924  48 ✔️  - 4 914  12 💤  - 10  0 ±0 

Results for commit b84cf2f. ± Comparison against base commit 25cc729.

@tgaddair tgaddair merged commit 55ab186 into master Mar 27, 2023
@tgaddair tgaddair deleted the fix-concat branch March 27, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants