Ensure that iq and all number feature preprocessing normalizations work on dask backends.
#3297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rk on dask backends.
…transformer about why we compute percentiles directly, without using the backend.
for more information, see https://pre-commit.ci
arnavgarg1
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iqpreprocessing for number features fails when using a ray/dask backend, with the following error:The
InterQuartileTransformerusesnp.percentile, which computes the percentile directly without deferring to the dask backend to execute the computation. This seems like the right thing to do as it looks like unlikecolumn.mean(), dask does not have a parallelized implementation ofnp.percentile.This PR removes the call to
.compute()inInterQuartileTransformer.fit_transform_params(), and adds tests to make sure that all preprocessing options in the registry succeed on both pandas and ray/dask backends.