-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Raise error if list provided to StringOptions
has duplicates and change validation errors to assertion errors for this field as well.
#3302
Conversation
@ksbrar were you going to change these to asserts? |
@tgaddair yes doing it now, was fixing other things |
Unit Test Results 6 files ± 0 6 suites ±0 59m 13s ⏱️ + 37m 2s For more details on these failures, see this check. Results for commit dd59940. ± Comparison against base commit 531e024. This pull request removes 4 and adds 2477 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
StringOptions
has duplicatesStringOptions
has duplicates and change validation errors to assertion errors for this field as well.
@tgaddair Switched to assertions, please re-review if you would like. |
No description provided.