Added trainer.gradient_accumulation_steps for increasing effective batch size
#3305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgaddair
changed the title
trainer.gradient_accumulation option for increasing effective batch sizetrainer.gradient_accumulation_steps for increasing effective batch size
justinxzhao
approved these changes
Mar 30, 2023
|
|
||
| # Just test that training completes without error. | ||
| # TODO(travis): We may want to expand upon this in the future to include some checks on model | ||
| # convergence like gradient magnitudes, etc. Should also add distributed tests. |
There was a problem hiding this comment.
Should we re-use the test utility for distributed tests?
run_test_suite(config, dataset, "ray")There was a problem hiding this comment.
I think we should refactor to be able to do this in a follow-up, yeah. The reason I didn't do it here is because that function is a lot more expensive, since it runs a lot more additional tests. But we should in general rely on some standard test suite functions that can run with different levels of checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benefits include: