Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add separate output config registries for ECD and GBM #3306

Merged
merged 1 commit into from
Mar 29, 2023
Merged

fix: Add separate output config registries for ECD and GBM #3306

merged 1 commit into from
Mar 29, 2023

Conversation

ksbrar
Copy link
Collaborator

@ksbrar ksbrar commented Mar 29, 2023

Separate output_config_registry into ecd_output_config_registry and gbm_output_config_registry.

@github-actions
Copy link

Unit Test Results

    6 files  ±    0      6 suites  ±0   3h 17m 58s ⏱️ + 2h 55m 47s
158 tests +146  141 ✔️ +131  17 💤 +15  0 ❌ ±0 
330 runs  +270  296 ✔️ +248  34 💤 +22  0 ❌ ±0 

Results for commit 0ad44b2. ± Comparison against base commit 531e024.

@ksbrar
Copy link
Collaborator Author

ksbrar commented Mar 29, 2023

Test failures in both cases are due to tests reaching ~80% coverage (all passing) but then hitting the max timeout. Other workflows all passed and I have high confidence in this change, so merging it in.

@ksbrar ksbrar merged commit 999eacd into master Mar 29, 2023
@ksbrar ksbrar deleted the separate-ecd-gbm-output-registries branch March 29, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgaddair tgaddair tgaddair approved these changes

@abidwael abidwael abidwael approved these changes

@justinxzhao justinxzhao Awaiting requested review from justinxzhao justinxzhao is a code owner

@jeffkinnison jeffkinnison Awaiting requested review from jeffkinnison jeffkinnison is a code owner

@connor-mccorm connor-mccorm Awaiting requested review from connor-mccorm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ksbrar @tgaddair @abidwael