Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use frac arg in df.sample instead of n #3307

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Use frac arg in df.sample instead of n #3307

merged 1 commit into from
Mar 30, 2023

Conversation

abidwael
Copy link
Contributor

No description provided.

@github-actions
Copy link

Unit Test Results

  6 files  +    1    6 suites  +1   23m 11s ⏱️ - 1h 24m 58s
12 tests  - 148  10 ✔️  - 133    2 💤  - 15  0 ±0 
60 runs   - 132  48 ✔️  - 121  12 💤  - 11  0 ±0 

Results for commit 29ba944. ± Comparison against base commit 999eacd.

This pull request removes 148 tests.
tests.integration_tests.test_automl ‑ test_auto_train
tests.integration_tests.test_automl ‑ test_autoconfig_preprocessing_balanced
tests.integration_tests.test_automl ‑ test_autoconfig_preprocessing_imbalanced
tests.integration_tests.test_automl ‑ test_autoconfig_preprocessing_text_image
tests.integration_tests.test_automl ‑ test_create_auto_config[image]
tests.integration_tests.test_automl ‑ test_create_auto_config[multimodal]
tests.integration_tests.test_automl ‑ test_create_auto_config[tabular_large]
tests.integration_tests.test_automl ‑ test_create_auto_config[tabular_small]
tests.integration_tests.test_automl ‑ test_create_auto_config[text]
tests.integration_tests.test_automl ‑ test_create_auto_config_with_dataset_profile
…

Copy link
Collaborator

@justinxzhao justinxzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you observe a boost in speed?

@abidwael
Copy link
Contributor Author

@abidwael abidwael merged commit fae723c into master Mar 30, 2023
@abidwael abidwael deleted the df-sample-use-frac branch March 30, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants