Pass encoding dimensions to SequenceCombiner

[RXminuS]

If this argument isn't passed along then the attention reducer doesn't work for me.

Note that although this fixes it for me I suspect there's lots of other places this would have to be applied. But maybe someone more experienced could chip in with if this is indeed an acceptable solution and other things to consider?

[github-actions]

Unit Test Results

  4 files  ±  0    4 suites  ±0   41m 42s ⏱️ + 12m 59s
33 tests ±  0  27 ✔️  - 3    6 💤 +3  0 ❌ ±0 
66 runs  +13  54 ✔️ +8  12 💤 +5  0 ❌ ±0 

Results for commit cc7b02b. ± Comparison against base commit e49eae9.

This pull request skips 3 tests.

tests.regression_tests.benchmark.test_model_performance ‑ test_performance[ames_housing.ecd.yaml]
tests.regression_tests.benchmark.test_model_performance ‑ test_performance[ames_housing.gbm.yaml]
tests.regression_tests.benchmark.test_model_performance ‑ test_performance[mercedes_benz_greener.gbm.yaml]

♻️ This comment has been updated with latest results.

[justinxzhao]

Hi @RXminuS,

The change looks reasonable to me!

We'd probably want to make the same change to all of the encoders in text_encoders that have reducers, but doing this for the Auto encoder first makes sense.

Not totally sure why all of the tests are failing in your PR though. I'll re-run the CI.

[RXminuS]

Cool, happy to expand the PR to the others once tests pass 👍 thanks for reviewing

[tgaddair]

Thanks for the contribution @RXminuS!

Most of these test failures look like issues with some recently added tests that use S3. So the fix on our side will simply be to exclude those tests when running from a fork. cc @abidwael

The only one I'm not sure on is tests/ludwig/profiling/test_metrics.py::test_get_column_profile_attributes. Seems unrelated to either this PR or credentials, so @justinxzhao would you be able to take a quick look to see what's going on?

[justinxzhao]

@tgaddair thanks for the pointers.

I've removed this test tests/ludwig/profiling/test_metrics.py::test_get_column_profile_attributes, so rebasing this PR (I've gone ahead and done this) should fix that test.

[justinxzhao]

I've also gone ahead and applied the private_param and private_test annotations which should hopefully take care of the other failing tests that depend on specific credentials.

[tgaddair]

LGTM! Thanks for the contribution :)

We should do a follow-up to address other occurrences of this issue.

[w4nderlust]

Thanks for the contribution Rik!