-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pandas 2.0 update #3322
Pandas 2.0 update #3322
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet! Just one comment, otherwise LGTM.
ludwig/benchmarking/profiler.py
Outdated
def get_gpu_info(): | ||
"""Gathers general hardware information about an nvidia GPU. | ||
|
||
:param args: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Remove empty docs.
If this is copied from the other repo, please reference it as a comment i.e.
Adapted from <link>, with additional adjustments for compatibility with Pandas 2.0.
@@ -20,19 +22,38 @@ | |||
from ludwig.globals import LUDWIG_VERSION | |||
from ludwig.utils.data_utils import save_json | |||
|
|||
# disabling print because the following imports are verbose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup.
The changes listed above should cover the 2.0 update, and as far as I can tell we should still be able to support 1.x because
|
Bumping the min version to 1.0 SGTM! |
Updates to make Ludwig compatible with Pandas 2.0. The current changes include:
experiment_impact_tracker
as a dependencyLudwigProfiler
to replicateexperiment_impact_tracker
CPU/GPU attribute collectiondf.iteritems()
->df.items()
df.append(df2)
->df_engine.concat([df, df2])
xls
files was removed. This only seems to impact one integration test.